Remove panic-prone .unwrap() calls from build_helper #146684
Conversation
Replace panic-prone .unwrap() calls with defensive error handling
rustbot
added
S-waiting-on-review
|
rustbot has assigned @Mark-Simulacrum. Use |
marcusDenslow
changed the title
|
Note: In stage0_parser.rs, malformed config lines are now skipped with a warning instead of panicking. I’m not sure if this should be a hard error instead (fail with a proper message). Feedback on that point would be appreciated. |
| let (key, value) = match line.split_once('=') { | ||
| Some((k, v)) => (k, v), | ||
| None => { | ||
| println!("Warning: Skipping malformed config line {}", line); | ||
| continue; | ||
| } | ||
| }; |
There was a problem hiding this comment.
Skipping malformed stage0 config lines with a warning might hide real issues in the user's stage0 config.
Would it be better to fail with a proper error message here instead (e.g. bail! or return Err(...)), so the user knows right away their config is broken?
small note: the warning currently uses println! We might want to change this to eprintln! so that it goes to stderr. open to feedback on whats prefferable
|
IMO, unwrap actually works pretty well for our purposes - it points directly at the code that's failing rather than requiring something else to trace to that location. So I don't actually think we should do something like this. Thanks! |
rustbot
removed
the
S-waiting-on-review
3 participants
Summary
Replace panic-prone
.unwrap()calls with defensive error handling in the buildhelper crate.
Problem
The build system could panic on malformed input from:
Solution
?operator for safe git diff-index parsing